Fix aws cli perms#132
Open
stevendborrelli wants to merge 3 commits into
Open
Conversation
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added cleanup step to remove temporary AWS CLI installation files (/aws and /tmp/awscliv2.zip) after installation, reducing the final image size. This also addresses some AWS CLI permissions when setting a different UID/GID.
Testing
Ran locally using UID/GID 2000:
$ docker run -it --rm --user 2000:2000 --entrypoint /bin/zsh index.docker.io/steve/function-shell:permfix 0467ea58ba81% id uid=2000 gid=2000 groups=2000 0467ea58ba81% aws sts get-caller-identity { "UserId": "xxx:steven@example.com", "Account": "abc", "Arn": "arn:aws:sts::abc:assumed-role/1234/steven@example.com" }Fixes #
I have:
contribution process. Also see docs.